Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate deprecated Table to DataTable for LearnerActivityTable #1288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Aug 30, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2024-09-13 at 9 13 39 AM

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8445 branch 4 times, most recently from ba9e97c to 8d44e3b Compare September 12, 2024 11:41
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 56.89655% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (115c430) to head (3637b96).

Files with missing lines Patch % Lines
...erActivityTable/data/hooks/useCourseEnrollments.js 26.47% 21 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   85.52%   85.37%   -0.15%     
==========================================
  Files         564      566       +2     
  Lines       12351    12397      +46     
  Branches     2621     2586      -35     
==========================================
+ Hits        10563    10584      +21     
- Misses       1729     1751      +22     
- Partials       59       62       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant